Skip to content

Fixes issue preventing propagation of Blur event when field value is null #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes issue preventing propagation of Blur event when field value is null #12

wants to merge 1 commit into from

Conversation

gvincentlh
Copy link

The local onBlur returns null when the input field has no value. Because result is then falsy, we never invoke the onBlur which is set on props. As long as there is a handler set on props, it should be called regardless of the input value.

joefiorini
joefiorini approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@joefiorini joefiorini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tom-zeit
Copy link

Hi, any chance to merge this fix? Will help me too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joefiorini joefiorini joefiorini approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvincentlh @tom-zeit @joefiorini